lordgamez commented on a change in pull request #1137:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r689670238
##########
File path: libminifi/test/TestBase.h
##########
@@ -164,6 +165,31 @@ class LogTestController {
return found;
}
+ std::optional<std::smatch> matchesRegex(const std::string ®ex_str,
Review comment:
The `matchesRegex` depends on the `log_output` member of the
`LogTestController` to retrieve and match the log output, and there is no way
currently to get the `log_output` outside of the class. We could check how it
influences the build times of other tests, but if it's not that big impact, I
would keep it as a utility for other use cases as well, and would not expose
the `log_output`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
