szaszm commented on a change in pull request #1161:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1161#discussion_r690477700



##########
File path: extensions/pcap/CMakeLists.txt
##########
@@ -19,11 +19,21 @@
 
 find_package(PCAP REQUIRED)
 
+include(FetchContent)
+
+FetchContent_Declare(pcapplusplus
+               URL      
https://github.com/seladb/PcapPlusPlus/archive/refs/tags/v21.05.tar.gz

Review comment:
       I prefer keeping the release tarball. It's faster to download and 
extract than cloning a git repo.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to