martinzink commented on a change in pull request #1161: URL: https://github.com/apache/nifi-minifi-cpp/pull/1161#discussion_r690603827
########## File path: extensions/pcap/CMakeLists.txt ########## @@ -19,11 +19,21 @@ find_package(PCAP REQUIRED) +include(FetchContent) + +FetchContent_Declare(pcapplusplus + URL https://github.com/seladb/PcapPlusPlus/archive/refs/tags/v21.05.tar.gz + URL_HASH SHA256=f7bc2caea72544f42e3547c8acf65fca07ddd4cd45f7be2f5132dd1826ea27bb + ) +if (NOT pcapplusplus_POPULATED) Review comment: Good catch, you are right, changed it to FetchContent_MakeAvailable in https://github.com/apache/nifi-minifi-cpp/pull/1161/commits/a513ff65eff18b5f0e2394ccaf9d3d9e1a51346a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
