exceptionfactory commented on a change in pull request #5332:
URL: https://github.com/apache/nifi/pull/5332#discussion_r696060096
##########
File path:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/NiFiLegacyCipherProviderGroovyTest.groovy
##########
@@ -260,9 +247,14 @@ class NiFiLegacyCipherProviderGroovyTest {
* from the password using a long digest result at the time of key length
checking.
* @throws IOException
*/
- @Ignore("Only needed once to determine max supported password lengths")
+ @Disabled("Only needed once to determine max supported password lengths")
+ @Ignore
@Test
void testShouldDetermineDependenceOnUnlimitedStrengthCrypto() throws
IOException {
+ if (true) {
+ return //Fix later
+ //TODO: junit5-fix
+ }
Review comment:
If migrating to JUnit 5 breaks the test, we should hold off on migrating
this module or test class.
##########
File path:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/HashServiceTest.groovy
##########
@@ -387,13 +367,13 @@ class HashServiceTest extends GroovyTestCase {
}
@Test
- void testShouldHashValueFromStream() throws Exception {
+ void testShouldHashValueFromStream(@TempDir Path temporaryFolder) throws
Exception {
// Arrange
// No command-line md2sum tool available
def algorithms = HashAlgorithm.values() - HashAlgorithm.MD2
- File inputFile = temporaryFolder.newFile()
+ File inputFile =
Files.createFile(temporaryFolder.resolve("test-${System.currentTimeMillis()}".toString())).toFile()
Review comment:
It appears that the automated build is still failing this test method on
Windows. It may be possible to refactor the test method to avoid writing files,
or to use `Files.createTempFile()` instead of using the temporary folder.
##########
File path:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/NiFiLegacyCipherProviderGroovyTest.groovy
##########
@@ -260,9 +247,14 @@ class NiFiLegacyCipherProviderGroovyTest {
* from the password using a long digest result at the time of key length
checking.
* @throws IOException
*/
- @Ignore("Only needed once to determine max supported password lengths")
+ @Disabled("Only needed once to determine max supported password lengths")
+ @Ignore
Review comment:
Instead of continuing to mark these tests as ignored, this seems like
the right opportunity to make the test conditional on an environment variable
or system property. JUnit 5 provides first-class support for this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
