exceptionfactory commented on a change in pull request #5332:
URL: https://github.com/apache/nifi/pull/5332#discussion_r697512891
##########
File path:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/NiFiLegacyCipherProviderGroovyTest.groovy
##########
@@ -260,9 +247,14 @@ class NiFiLegacyCipherProviderGroovyTest {
* from the password using a long digest result at the time of key length
checking.
* @throws IOException
*/
- @Ignore("Only needed once to determine max supported password lengths")
+ @Disabled("Only needed once to determine max supported password lengths")
+ @Ignore
@Test
void testShouldDetermineDependenceOnUnlimitedStrengthCrypto() throws
IOException {
+ if (true) {
+ return //Fix later
+ //TODO: junit5-fix
+ }
Review comment:
Looking more closely at this specific test method, I recommend removing
it completely. Java 8 has supported unlimited strength cryptography policies by
default since [Java 8 Update
161](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8170157). There
should be a separate effort to remove conditionals within runtime code, but for
the purposes of this PR, removing the test method seems to be the best option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
