Lehel44 opened a new pull request #5356:
URL: https://github.com/apache/nifi/pull/5356
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Added command-line option to save status history in JSON.
**Details**
When you run _nifi.sh_ with a command line option, the _RunNiFi_ class
parses the options, creates a _NiFi_ server instance, and sends a request to
the _BootstrapListener_ on the server. Objects from _nifi-core_ can be injected
by spring web context. Since only a single _NiFiServer_ instance can be
accessed via _BootstrapListener_, I extended it with a new method that returns
the status history.
- Outsourced _StatusHistoryRepository_ creation to a factory bean from
_FlowController_ in order to use it in _nifi-runtime_.
- The _NiFiServer_ interface has been extended with the _String
getNodeStatusHistoryJson(final int days);_ method. (Returns a string in order
to avoid additional dependencies in nifi-bootstrap. Dependencies in
nifi-runtime affect nifi-bootstrap as well, and they must be added to
assembly/common.xml filters.)
- Extended _RunNiFi_ and _nifi.sh_ with the new status-history option.
- The StatusHistoryRepository gets injected into JettyServer which can be
accessed by NiFiBootstrap.
**Still under consideration or work in progress:**
- NiFiServer: default vs not default method?
- Extend admin guide
https://issues.apache.org/jira/browse/NIFI-9183
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
