Lehel44 commented on a change in pull request #5356:
URL: https://github.com/apache/nifi/pull/5356#discussion_r712516200



##########
File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
##########
@@ -216,6 +220,30 @@ public static void main(String[] args) throws IOException, 
InterruptedException
                 dumpFile = null;
                 verbose = false;
             }
+        } else if (cmd.equalsIgnoreCase("status-history")) {
+            if (args.length != 4) {
+                System.err.printf("Wrong number of arguments: %d instead of 4, 
the command parameters are: " +
+                        "status-history --days <number of days> <dumpFile>%n", 
args.length);

Review comment:
       I agree to remove the --days option; I will add an optional 1 day 
default value to it, however I would not change the order because the 
diagnostic command follows the same order of params.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to