szaszm commented on a change in pull request #1177:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1177#discussion_r713772532
##########
File path: libminifi/include/io/AtomicEntryStream.h
##########
@@ -108,6 +112,11 @@ void AtomicEntryStream<T>::seek(size_t offset) {
offset_ = gsl::narrow<size_t>(offset);
}
+template<typename T>
+size_t AtomicEntryStream<T>::tell() const {
+ return offset_;
+}
Review comment:
I would move this inline in the class definition. The implementation is
trivial, so it wouldn't hurt readability IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
