martinzink commented on a change in pull request #1177:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1177#discussion_r714722272
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -290,6 +290,33 @@ void ProcessSession::append(const
std::shared_ptr<core::FlowFile> &flow, OutputS
}
}
+namespace {
+// FlowFileStream uses the flowfile's size instead of the stream size (so it
will not be over-read)
+class FlowFileStream : public io::BaseStream {
Review comment:
Good idea.
I also changed seek() to work properly from the beginning of the slice
(instead of the stream).
Added also a couple more unit tests.
https://github.com/apache/nifi-minifi-cpp/pull/1177/commits/0a442efb33954be698d0ed5daa5148ab5f3bd02b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
