lordgamez commented on a change in pull request #1178: URL: https://github.com/apache/nifi-minifi-cpp/pull/1178#discussion_r720341394
########## File path: extensions/azure/storage/AzureStorageClient.h ########## @@ -0,0 +1,34 @@ +/** + * @file AzureStorageClient.h + * AzureStorageClient class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include "AzureStorageCredentials.h" + +namespace org::apache::nifi::minifi::azure::storage { + +class AzureStorageClient { + public: + virtual ~AzureStorageClient() = default; + + protected: + AzureStorageCredentials credentials_; +}; Review comment: I agree, it's better to keep it as an interface without any members, moved the member in b2847320d940d1a53fe5070b749dbd35b4a9d64c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
