szaszm commented on a change in pull request #1178:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1178#discussion_r720908915
##########
File path: extensions/azure/storage/AzureBlobStorage.h
##########
@@ -24,33 +24,29 @@
#include <string>
#include <vector>
-#include "BlobStorage.h"
+#include "BlobStorageClient.h"
#include "azure/storage/blobs.hpp"
#include "core/logging/Logger.h"
#include "core/logging/LoggerConfiguration.h"
+#include "gsl/gsl-lite.hpp"
Review comment:
When introducing gsl-lite to the codebase, I created `"utils/gsl.h"`
with the intention of it being the common entry point from minifi to gsl,
including a namespace alias of `::org::apache::nifi::minifi::gsl` to
`::gsl_lite`, following [gsl-lite's own guidelines for
libraries](https://github.com/gsl-lite/gsl-lite#using-gsl-lite-in-libraries). I
also introduced one gsl-related utility in the same file, but I'm open to
moving that elsewhere.
Consider using `"utils/gsl.h"` and the namespace alias to access gsl-lite
functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
