ChrisSamo632 commented on a change in pull request #4693:
URL: https://github.com/apache/nifi/pull/4693#discussion_r724354340
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java
##########
@@ -182,8 +181,8 @@ private Response runQuery(final String endpoint, final
String query, final Strin
final HttpEntity queryEntity = new NStringEntity(query,
ContentType.APPLICATION_JSON);
try {
- return client.performRequest("POST", sb.toString(),
requestParameters != null ? requestParameters : Collections.emptyMap(),
queryEntity);
- } catch (final Exception e) {
+ return performRequest("POST", sb.toString(), requestParameters,
queryEntity);
Review comment:
Not sure what you want to be `final` here? I've applied `final` to
everywhere I can see it may be usable within the class (there were a couple of
things I'd missed previously, but this line isn't assigning any variables, so
there's nothing to make `final`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
