ChrisSamo632 commented on a change in pull request #4693: URL: https://github.com/apache/nifi/pull/4693#discussion_r724390382
########## File path: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/groovy/org/apache/nifi/processors/elasticsearch/AbstractByQueryElasticsearchTest.groovy ########## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License") you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.processors.elasticsearch + +import org.apache.nifi.util.MockFlowFile +import org.apache.nifi.util.TestRunner +import org.junit.Assert +import org.junit.Test + +abstract class AbstractByQueryElasticsearchTest { Review comment: While it should be fairly straight forward to convert them, I think that should be part of a larger initiative if/when decided upon. Also, we couldn't convert just this one class, we'd need to convert all of the tests (pretty much) in this package. Also, currently, all the tests in the package are Groovy and not Java, I think moving just a sub-set of the tests would lead to more confusion rather than solving anything. Maybe we should raise a follow-on Jira ticket to suggest the move and see what people think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
