fgerlits commented on a change in pull request #1205: URL: https://github.com/apache/nifi-minifi-cpp/pull/1205#discussion_r737234307
########## File path: extensions/sftp/tests/ListSFTPTests.cpp ########## @@ -223,6 +223,7 @@ TEST_CASE_METHOD(ListSFTPTestsFixture, "ListSFTP list non-readable dir", "[ListS REQUIRE(false == LogTestController::getInstance().contains("from ListSFTP to relationship success")); REQUIRE(LogTestController::getInstance().contains("Failed to open remote directory \"nifi_test\", error: LIBSSH2_FX_PERMISSION_DENIED")); REQUIRE(LogTestController::getInstance().contains("There are no files to list. Yielding.")); + REQUIRE(0 == chmod((src_dir + "/vfs/nifi_test").c_str(), 0755)); Review comment: Elsewhere in these tests, we use 0644 as the permissive protection setting; why did you choose 0755 in this PR? ########## File path: extensions/sftp/tests/FetchSFTPTests.cpp ########## @@ -326,6 +326,7 @@ TEST_CASE_METHOD(FetchSFTPTestsFixture, "FetchSFTP Completion Strategy Delete Fi REQUIRE(LogTestController::getInstance().contains("key:sftp.remote.port value:" + std::to_string(sftp_server->getPort()))); REQUIRE(LogTestController::getInstance().contains("key:path value:nifi_test/")); REQUIRE(LogTestController::getInstance().contains("key:filename value:tstFile.ext")); + REQUIRE(0 == chmod((src_dir + "/vfs/nifi_test").c_str(), 0755)); Review comment: do we need to add this at line 264, too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org