lordgamez commented on a change in pull request #1205:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1205#discussion_r737458185
##########
File path: extensions/sftp/tests/FetchSFTPTests.cpp
##########
@@ -326,6 +326,7 @@ TEST_CASE_METHOD(FetchSFTPTestsFixture, "FetchSFTP
Completion Strategy Delete Fi
REQUIRE(LogTestController::getInstance().contains("key:sftp.remote.port
value:" + std::to_string(sftp_server->getPort())));
REQUIRE(LogTestController::getInstance().contains("key:path
value:nifi_test/"));
REQUIRE(LogTestController::getInstance().contains("key:filename
value:tstFile.ext"));
+ REQUIRE(0 == chmod((src_dir + "/vfs/nifi_test").c_str(), 0755));
Review comment:
It looks like it's not needed there, even though it doesn't have write
permission, the file can and will be deleted on cleanup. That's because we
delete a file in that case not a directory and "All rm needs is write+execute
permission on the parent directory. The permissions of the file itself are
irrelevant.".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
