Github user ishiyayu commented on the issue:
https://github.com/apache/nifi/pull/1165
2016/10/28 åå6:32 "Bryan Rosander" <[email protected]>:
> Thank you for submitting a contribution to Apache NiFi.
>
> In order to streamline the review of the contribution we ask you
> to ensure the following steps have been taken:
> For all changes:
>
> -
>
> Is there a JIRA ticket associated with this PR? Is it referenced
> in the commit message?
> -
>
> Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
> you are trying to resolve? Pay particular attention to the hyphen "-"
> character.
> -
>
> Has your PR been rebased against the latest commit within the target
> branch (typically master)?
> -
>
> Is your initial contribution a single, squashed commit?
>
> For code changes:
>
> - Have you ensured that the full suite of tests is executed via mvn
> -Pcontrib-check clean install at the root nifi folder?
> - Have you written or updated unit tests to verify your changes?
> - N/A - If adding new dependencies to the code, are these dependencies
> licensed in a way that is compatible for inclusion under ASF 2.0
> <http://www.apache.org/legal/resolved.html#category-a>?
> - N/A - If applicable, have you updated the LICENSE file, including
> the main LICENSE file under nifi-assembly?
> - N/A - If applicable, have you updated the NOTICE file, including the
> main NOTICE file found under nifi-assembly?
> - N/A - If adding new Properties, have you added .displayName in
> addition to .name (programmatic access) for each of the new properties?
>
> For documentation related changes:
>
> - Have you ensured that format looks appropriate for the output in
> which it is rendered?
>
> Note:
>
> Please ensure that once the PR is submitted, you check travis-ci for build
> issues and submit an update to your PR as soon as possible.
>
> 1. loading pkcs12 keystores with bouncy castle everywhere
> 2. tls-toolkit client using jks truststore when keystore type is
> specified differently
> 3. tests
>
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/nifi/pull/1165
> Commit Summary
>
> - NIFI-2943 - pkcs12 keystore improvements
>
> File Changes
>
> - *M* nifi-commons/nifi-security-utils/src/main/java/org/
> apache/nifi/security/util/CertificateUtils.java
> <https://github.com/apache/nifi/pull/1165/files#diff-0> (7)
> - *A* nifi-commons/nifi-security-utils/src/main/java/org/
> apache/nifi/security/util/KeyStoreUtils.java
> <https://github.com/apache/nifi/pull/1165/files#diff-1> (62)
> - *M* nifi-commons/nifi-security-utils/src/main/java/org/
> apache/nifi/security/util/SslContextFactory.java
> <https://github.com/apache/nifi/pull/1165/files#diff-2> (8)
> - *M* nifi-commons/nifi-security-utils/src/test/groovy/org/
> apache/nifi/security/util/CertificateUtilsTest.groovy
> <https://github.com/apache/nifi/pull/1165/files#diff-3> (4)
> - *A* nifi-commons/nifi-security-utils/src/test/java/org/
> apache/nifi/security/util/KeyStoreUtilsTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-4> (139)
> - *M* nifi-commons/nifi-site-to-site-client/src/main/java/org/
> apache/nifi/remote/client/SiteToSiteClient.java
> <https://github.com/apache/nifi/pull/1165/files#diff-5> (5)
> - *M* nifi-commons/nifi-socket-utils/src/main/java/org/
> apache/nifi/io/socket/SSLContextFactory.java
> <https://github.com/apache/nifi/pull/1165/files#diff-6> (5)
> - *M* nifi-docs/src/main/asciidoc/administration-guide.adoc
> <https://github.com/apache/nifi/pull/1165/files#diff-7> (4)
> - *M* nifi-nar-bundles/nifi-framework-bundle/nifi-
> framework/nifi-security/src/main/java/org/apache/nifi/
> framework/security/util/SslContextFactory.java
> <https://github.com/apache/nifi/pull/1165/files#diff-8> (7)
> - *M* nifi-nar-bundles/nifi-framework-bundle/nifi-
> framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/
> web/server/JettyServer.java
> <https://github.com/apache/nifi/pull/1165/files#diff-9> (19)
> - *M* nifi-nar-bundles/nifi-framework-bundle/nifi-
> framework/nifi-web/nifi-jetty/src/test/java/org/apache/nifi/
> web/server/JettyServerTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-10> (62)
> - *M* nifi-nar-bundles/nifi-framework-bundle/nifi-
> framework/nifi-web/nifi-web-security/src/main/java/org/
> apache/nifi/web/security/x509/ocsp/OcspCertificateValidator.java
> <https://github.com/apache/nifi/pull/1165/files#diff-11> (3)
> - *M* nifi-nar-bundles/nifi-standard-bundle/nifi-standard-
> processors/src/main/java/org/apache/nifi/processors/
> standard/GetHTTP.java
> <https://github.com/apache/nifi/pull/1165/files#diff-12> (5)
> - *M* nifi-nar-bundles/nifi-standard-bundle/nifi-standard-
> processors/src/main/java/org/apache/nifi/processors/
> standard/PostHTTP.java
> <https://github.com/apache/nifi/pull/1165/files#diff-13> (5)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/
> toolkit/tls/configuration/TlsClientConfig.java
> <https://github.com/apache/nifi/pull/1165/files#diff-14> (1)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/
> toolkit/tls/manager/BaseTlsManager.java
> <https://github.com/apache/nifi/pull/1165/files#diff-15> (18)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/
> toolkit/tls/service/client/TlsCertificateAuthorityClientC
> ommandLine.java
> <https://github.com/apache/nifi/pull/1165/files#diff-16> (5)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/
> toolkit/tls/service/server/TlsCertificateAuthorityService
> CommandLine.java
> <https://github.com/apache/nifi/pull/1165/files#diff-17> (2)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/
> toolkit/tls/standalone/TlsToolkitStandalone.java
> <https://github.com/apache/nifi/pull/1165/files#diff-18> (6)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/
> toolkit/tls/standalone/TlsToolkitStandaloneCommandLine.java
> <https://github.com/apache/nifi/pull/1165/files#diff-19> (2)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/
> toolkit/tls/util/TlsHelper.java
> <https://github.com/apache/nifi/pull/1165/files#diff-20> (5)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/test/java/org/apache/nifi/
> toolkit/tls/service/TlsCertificateAuthorityTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-21> (46)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/test/java/org/apache/nifi/
> toolkit/tls/service/client/TlsCertificateAuthorityClientC
> ommandLineTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-22> (6)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/test/java/org/apache/nifi/
> toolkit/tls/service/client/TlsCertificateSigningRequestPe
> rformerTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-23> (6)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/test/java/org/apache/nifi/
> toolkit/tls/service/server/TlsCertificateAuthorityService
> HandlerTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-24> (6)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/test/java/org/apache/nifi/
> toolkit/tls/standalone/TlsToolkitStandaloneTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-25> (29)
> - *M* nifi-toolkit/nifi-toolkit-tls/src/test/java/org/apache/nifi/
> toolkit/tls/util/TlsHelperTest.java
> <https://github.com/apache/nifi/pull/1165/files#diff-26> (7)
>
> Patch Links:
>
> - https://github.com/apache/nifi/pull/1165.patch
> - https://github.com/apache/nifi/pull/1165.diff
>
> â
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nifi/pull/1165>, or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AEjw8-yOGAvv4Y2U1UOLHu26boUzUwdMks5q4RiBgaJpZM4Ki2XQ>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
