Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1165#discussion_r88095962
--- Diff:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/commandLine/BaseCommandLine.java
---
@@ -202,6 +206,10 @@ protected CommandLine doParse(String[] args) throws
CommandLineParseException {
keySize = getIntValue(commandLine, KEY_SIZE_ARG,
TlsConfig.DEFAULT_KEY_SIZE);
keyAlgorithm = commandLine.getOptionValue(KEY_ALGORITHM_ARG,
TlsConfig.DEFAULT_KEY_PAIR_ALGORITHM);
keyStoreType = commandLine.getOptionValue(KEY_STORE_TYPE_ARG,
getKeyStoreTypeDefault());
+ if
(KeystoreType.PKCS12.toString().equalsIgnoreCase(keyStoreType)) {
+ logger.info("Command line argument --" +
KEY_STORE_TYPE_ARG + "=" + keyStoreType + " only applies to keyStore,
recommended trustStore type of " + KeystoreType.JKS.toString() +
--- End diff --
Same minor comment on capitalization (of output message; variable names are
fine).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
