martinzink commented on a change in pull request #1219:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1219#discussion_r777461024
##########
File path: docker/test/integration/minifi/core/SplunkContainer.py
##########
@@ -0,0 +1,26 @@
+import logging
+from .Container import Container
+
+
+class SplunkContainer(Container):
+ def __init__(self, name, vols, network, image_store):
+ super().__init__(name, 'splunk', vols, network, image_store)
+
+ def get_startup_finished_log_entry(self):
+ return "Ansible playbook complete, will begin streaming
splunkd_stderr.log"
+
+ def deploy(self):
+ if not self.set_deployed():
+ return
+
+ logging.info('Creating and running Splunk docker container...')
+ self.client.containers.run(
+ self.image_store.get_image(self.get_engine()),
+ detach=True,
+ name=self.name,
+ network=self.network.name,
+ environment=[
+ "SPLUNK_START_ARGS=--accept-license",
Review comment:
They have different license terms based on the type we are using.
https://docs.splunk.com/Documentation/Splunk/8.2.4/Admin/TypesofSplunklicenses
The whole eula can be found here: https://www.splunk.com/eula/sii/1.4
I changed this section in
https://github.com/apache/nifi-minifi-cpp/pull/1219/commits/b79afdea234a890818fa39c6a5ded4fb5fc117d8
so we explicity accept the free license which can be used to for these kinds
of tests(we only use this container for the integration tests) more about it
here:
https://docs.splunk.com/Documentation/Splunk/8.2.4/Admin/TypesofSplunklicenses#Free_license
##########
File path: extensions/splunk/PutSplunkHTTP.h
##########
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <string>
+#include <memory>
+
+#include "SplunkHECProcessor.h"
+#include "utils/gsl.h"
+
+namespace org::apache::nifi::minifi::extensions::splunk {
+
+class PutSplunkHTTP final : public SplunkHECProcessor {
Review comment:
fixed in
https://github.com/apache/nifi-minifi-cpp/pull/1219/commits/25e4878262c6ec80237339cd7388e7caab830ea0#diff-fffe34ee91301ca41f9e7bc23592fde7ae3205eb7e6e7c0c4e796694b5babac6R51-R54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
