szaszm commented on a change in pull request #1219:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1219#discussion_r777581938
##########
File path: libminifi/include/utils/TimeUtil.h
##########
@@ -37,6 +37,24 @@ namespace minifi {
namespace utils {
namespace timeutils {
+/**
+ * Converts the time point to the elapsed time since epoch
+ * @returns TimeUnit since epoch
+ */
+template<typename TimeUnit, typename TimePoint>
+uint64_t getTimestamp(const TimePoint& time_point) {
+ return
std::chrono::duration_cast<TimeUnit>(time_point.time_since_epoch()).count();
+}
+
+/**
+ * Converts the time since epoch into a time point
+ * @returns the time point matching the input timestamp
+ */
+template<typename TimeUnit, typename ClockType>
+std::chrono::time_point<ClockType> getTimePoint(uint64_t timestamp) {
+ return std::chrono::time_point<ClockType>() + TimeUnit(timestamp);
+}
Review comment:
I criticized these in your other PR, which would apply here, too. If you
think that they are useful, feel free to reintroduce them there, but if they
don't improve the readability, you may want to consider removing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
