szaszm commented on a change in pull request #1208:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1208#discussion_r779714817
##########
File path: libminifi/include/core/ProcessContext.h
##########
@@ -113,10 +113,13 @@ class ProcessContext : public
controller::ControllerServiceLookup, public core::
}
template<typename T>
- bool getProperty(const std::string &name, T &value) const {
+ std::enable_if_t<!std::is_convertible_v<T&, FlowFile&>, bool>
getProperty(const std::string &name, T &value) const {
Review comment:
I think I just generally don't like using `std::string` for a property
and didn't want to rely on that type as a discriminator. It compiles with this
restriction removed, but I think it's helpful to fail early in this case if
someone tries to use a missing overload `(property_name, flow_file) ->
optional<T>`.
It also adds complexity to the code, so I can remove it if you think that
would be an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
