adamdebreceni commented on a change in pull request #1208:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1208#discussion_r780130483
##########
File path: libminifi/include/core/ProcessContext.h
##########
@@ -113,10 +113,13 @@ class ProcessContext : public
controller::ControllerServiceLookup, public core::
}
template<typename T>
- bool getProperty(const std::string &name, T &value) const {
+ std::enable_if_t<!std::is_convertible_v<T&, FlowFile&>, bool>
getProperty(const std::string &name, T &value) const {
Review comment:
I think that the added requirement on this method has merit, but
currently nothing verifies it, IMO a test that checks that
`ctx.getProperty("blah", flowfile)` does not compile (or something along these
lines) would help cement its purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
