szaszm commented on a change in pull request #1238:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783248145
##########
File path: extensions/sql/data/SQLIdentifier.h
##########
@@ -19,18 +19,40 @@
#pragma once
#include <string>
-#include <vector>
+#include <functional>
-namespace org {
-namespace apache {
-namespace nifi {
-namespace minifi {
-namespace utils {
+namespace org::apache::nifi::minifi::sql {
-std::vector<std::string> inputStringToList(const std::string& str);
+class SQLIdentifier {
Review comment:
I suggest renaming this to something like `SqlColumnName` to avoid
confusion. "Identifier" typically refers to a primary key in the relational
database context. "Column" is not the most precise term (that would be
"attribute"), but it's the most intuitive.
And I suggest avoiding full-caps acronyms in CamelCase, because it makes it
more difficult to determine word boundaries (e.g. `IXMLHTTPRequest`) and to
programmatically convert between conventions (e.g. `s_q_l_identifier` instead
of `sql_identifier`). It's also recommended in the [google style
guide](https://google.github.io/styleguide/cppguide.html#General_Naming_Rules).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
