szaszm commented on a change in pull request #1238:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783820974
##########
File path: extensions/sql/data/SQLIdentifier.h
##########
@@ -19,18 +19,40 @@
#pragma once
#include <string>
-#include <vector>
+#include <functional>
-namespace org {
-namespace apache {
-namespace nifi {
-namespace minifi {
-namespace utils {
+namespace org::apache::nifi::minifi::sql {
-std::vector<std::string> inputStringToList(const std::string& str);
+class SQLIdentifier {
Review comment:
fair. What do you think about `SQLColumnIdentifier`? Or do you intend
this to be applicable to table and other identifiers as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
