szaszm commented on a change in pull request #1250: URL: https://github.com/apache/nifi-minifi-cpp/pull/1250#discussion_r790856199
########## File path: extensions/azure/processors/FetchAzureBlobStorage.cpp ########## @@ -0,0 +1,146 @@ +/** + * @file FetchAzureBlobStorage.cpp + * FetchAzureBlobStorage class implementation + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "FetchAzureBlobStorage.h" + +#include "core/Resource.h" +#include "utils/ProcessorConfigUtils.h" + +namespace org::apache::nifi::minifi::azure::processors { + +const core::Property FetchAzureBlobStorage::RangeStart( + core::PropertyBuilder::createProperty("Range Start") + ->withDescription("The byte position at which to start reading from the blob. An empty value or a value of zero will start reading at the beginning of the blob.") + ->supportsExpressionLanguage(true) + ->build()); +const core::Property FetchAzureBlobStorage::RangeLength( + core::PropertyBuilder::createProperty("Range Length") + ->withDescription("The number of bytes to download from the blob, starting from the Range Start. " + "An empty value or a value that extends beyond the end of the blob will read to the end of the blob.") + ->supportsExpressionLanguage(true) + ->build()); + +const core::Relationship FetchAzureBlobStorage::Success("success", "All successfully processed FlowFiles are routed to this relationship"); +const core::Relationship FetchAzureBlobStorage::Failure("failure", "Unsuccessful operations will be transferred to the failure relationship"); + +namespace { +class WriteCallback : public OutputStreamCallback { + public: + WriteCallback(storage::AzureBlobStorage& azure_blob_storage, const storage::FetchAzureBlobStorageParameters& params, std::shared_ptr<core::logging::Logger> logger) + : azure_blob_storage_(azure_blob_storage), + params_(params), + logger_(std::move(logger)) { Review comment: The logger is not used, consider removing it. ########## File path: extensions/azure/processors/FetchAzureBlobStorage.h ########## @@ -0,0 +1,72 @@ +/** + * @file FetchAzureBlobStorage.h + * FetchAzureBlobStorage class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <utility> +#include <vector> + +#include "core/Property.h" +#include "AzureBlobStorageProcessorBase.h" +#include "core/logging/LoggerConfiguration.h" + +template<typename T> +class AzureBlobStorageTestsFixture; + +namespace org::apache::nifi::minifi::azure::processors { + +class FetchAzureBlobStorage final : public AzureBlobStorageProcessorBase { + public: + // Supported Properties + EXTENSIONAPI static const core::Property RangeStart; + EXTENSIONAPI static const core::Property RangeLength; + + // Supported Relationships Review comment: The comment about properties is misleading, because there are more supported properties. The one about relationships is just redundant, because it's obvious from the context. Consider removing them. ########## File path: extensions/azure/processors/FetchAzureBlobStorage.cpp ########## @@ -0,0 +1,146 @@ +/** + * @file FetchAzureBlobStorage.cpp + * FetchAzureBlobStorage class implementation + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "FetchAzureBlobStorage.h" + +#include "core/Resource.h" +#include "utils/ProcessorConfigUtils.h" + +namespace org::apache::nifi::minifi::azure::processors { + +const core::Property FetchAzureBlobStorage::RangeStart( + core::PropertyBuilder::createProperty("Range Start") + ->withDescription("The byte position at which to start reading from the blob. An empty value or a value of zero will start reading at the beginning of the blob.") + ->supportsExpressionLanguage(true) + ->build()); +const core::Property FetchAzureBlobStorage::RangeLength( + core::PropertyBuilder::createProperty("Range Length") + ->withDescription("The number of bytes to download from the blob, starting from the Range Start. " + "An empty value or a value that extends beyond the end of the blob will read to the end of the blob.") + ->supportsExpressionLanguage(true) + ->build()); + +const core::Relationship FetchAzureBlobStorage::Success("success", "All successfully processed FlowFiles are routed to this relationship"); +const core::Relationship FetchAzureBlobStorage::Failure("failure", "Unsuccessful operations will be transferred to the failure relationship"); + +namespace { +class WriteCallback : public OutputStreamCallback { + public: + WriteCallback(storage::AzureBlobStorage& azure_blob_storage, const storage::FetchAzureBlobStorageParameters& params, std::shared_ptr<core::logging::Logger> logger) + : azure_blob_storage_(azure_blob_storage), + params_(params), + logger_(std::move(logger)) { + } + + int64_t process(const std::shared_ptr<io::BaseStream>& stream) override { + result_size_ = azure_blob_storage_.fetchBlob(params_, *stream); + if (!result_size_) { + return 0; + } + + return gsl::narrow<int64_t>(*result_size_); + } + + auto getResult() const { Review comment: Clang-Tidy: Function 'getResult' should be marked [[nodiscard]] My thoughts: maybe it should be a public data member? ########## File path: extensions/azure/processors/FetchAzureBlobStorage.h ########## @@ -0,0 +1,72 @@ +/** + * @file FetchAzureBlobStorage.h + * FetchAzureBlobStorage class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <utility> +#include <vector> + +#include "core/Property.h" +#include "AzureBlobStorageProcessorBase.h" +#include "core/logging/LoggerConfiguration.h" + +template<typename T> +class AzureBlobStorageTestsFixture; + +namespace org::apache::nifi::minifi::azure::processors { + +class FetchAzureBlobStorage final : public AzureBlobStorageProcessorBase { + public: + // Supported Properties + EXTENSIONAPI static const core::Property RangeStart; + EXTENSIONAPI static const core::Property RangeLength; + + // Supported Relationships + static const core::Relationship Failure; + static const core::Relationship Success; + + explicit FetchAzureBlobStorage(const std::string& name, const minifi::utils::Identifier& uuid = minifi::utils::Identifier()) + : FetchAzureBlobStorage(name, uuid, nullptr) { + } + + void initialize() override; + void onTrigger(const std::shared_ptr<core::ProcessContext> &context, const std::shared_ptr<core::ProcessSession> &session) override; + + private: + friend class ::AzureBlobStorageTestsFixture<FetchAzureBlobStorage>; + + core::annotation::Input getInputRequirement() const override { + return core::annotation::Input::INPUT_REQUIRED; + } + + explicit FetchAzureBlobStorage(const std::string& name, const minifi::utils::Identifier& uuid, std::unique_ptr<storage::BlobStorageClient> blob_storage_client) + : AzureBlobStorageProcessorBase(name, uuid, core::logging::LoggerFactory<FetchAzureBlobStorage>::getLogger(), std::move(blob_storage_client)) { + } + + std::optional<storage::FetchAzureBlobStorageParameters> buildFetchAzureBlobStorageParameters( + core::ProcessContext &context, const std::shared_ptr<core::FlowFile> &flow_file); + + storage::OptionalDeletion optional_deletion_; Review comment: Unused data member. Did you mean to implement another feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
