szaszm commented on a change in pull request #1250:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1250#discussion_r790864423
##########
File path: extensions/azure/storage/AzureBlobStorage.cpp
##########
@@ -74,4 +75,14 @@ bool AzureBlobStorage::deleteBlob(const
DeleteAzureBlobStorageParameters& params
}
}
+std::optional<uint64_t> AzureBlobStorage::fetchBlob(const
FetchAzureBlobStorageParameters& params, io::BaseStream& stream) {
+ try {
+ auto fetch_res = blob_storage_client_->fetchBlob(params);
+ return internal::pipe(fetch_res.get(), &stream);
Review comment:
What do you think about returning an `InputStream` instead of piping its
contents into an `OutputStream`? The caller could still do a piping if they
wanted, but they may also be able to use the `InputStream` in a more efficient
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
