tpalfy commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1020451641
I'm not sure this approach is what we want. The ```nifi-dbcp-shared``` would be basically ```nifi-dbcp-service``` itself. But more importantly, to my understanding we don't want to cut up modules and extract implementation code that can only be used by a select few modules in general. Unless the common code is very general and can be used by any module we want to maintain a fairly flat module hierarchy. If that is true, I don't see why this case would be an exception. But maybe I'm wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
