tpalfy commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021512187
I thought it's a good idea to separate ```.name()``` and ```.displayName()```. With that I'd leave the ```onConfigured()``` as well. There's no real business logic duplication just straightforward configuration. I think that is fine. I can remove the ```getSupportedDynamicPropertyDescriptor``` but I left the ```getDriver``` method intentionally because the ```Class.forName``` needs to be called there, otherwise it's not be able to find the driver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
