[
https://issues.apache.org/jira/browse/NIFI-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629460#comment-15629460
]
ASF GitHub Bot commented on NIFI-2971:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/1172
NIFI-2971 moved properties loading into its own bootstrap classloader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-2971
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1172
----
commit 4e13e965d15d648603663d5bcf39683046326cdb
Author: joewitt <[email protected]>
Date: 2016-11-02T13:51:47Z
NIFI-2971 moved properties loading into its own bootstrap classloader
----
> bcprov and commons-lang usage in application classloader
> --------------------------------------------------------
>
> Key: NIFI-2971
> URL: https://issues.apache.org/jira/browse/NIFI-2971
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Tools and Build
> Affects Versions: 1.0.0
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Priority: Blocker
> Fix For: 1.1.0
>
>
> In reviewing NIFI-2954 it was noticed that the work in NIFI-1831 led to
> bcprov and commons-lang3 entering the root application classloader which
> pollutes all classloaders. The only things that should be in the root
> classloader are logging libraries, the nifi api, and a way to bootstrap the
> application.
> These dependencies need to get moved into the nar and executed via the nifi
> startup routine
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
