[
https://issues.apache.org/jira/browse/NIFI-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629593#comment-15629593
]
ASF GitHub Bot commented on NIFI-2971:
--------------------------------------
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1172#discussion_r86186622
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-runtime/src/main/java/org/apache/nifi/NiFi.java
---
@@ -55,6 +59,25 @@
public static final String BOOTSTRAP_PORT_PROPERTY =
"nifi.bootstrap.listen.port";
private volatile boolean shutdown = false;
+ private static final ClassLoader BOOTSTRAP_CLASSLOADER;
+
+ static {
+ //Get list of files in bootstrap folder
+ final List<URL> urls = new ArrayList<>();
+ try {
+ Files.list(Paths.get("lib/bootstrap")).forEach(p -> {
+ try {
+ urls.add(p.toUri().toURL());
+ } catch (final MalformedURLException mef) {
+ logger.warn("Unable to load " + p.getFileName() + "
due to " + mef, mef);
+ }
+ });
+ } catch (final IOException ex) {
+ logger.error("Unable to properly initialize bootstrap
classloader due to " + ex, ex);
--- End diff --
Does this mean we can/should continue?
> bcprov and commons-lang usage in application classloader
> --------------------------------------------------------
>
> Key: NIFI-2971
> URL: https://issues.apache.org/jira/browse/NIFI-2971
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Tools and Build
> Affects Versions: 1.0.0
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Priority: Blocker
> Fix For: 1.1.0
>
>
> In reviewing NIFI-2954 it was noticed that the work in NIFI-1831 led to
> bcprov and commons-lang3 entering the root application classloader which
> pollutes all classloaders. The only things that should be in the root
> classloader are logging libraries, the nifi api, and a way to bootstrap the
> application.
> These dependencies need to get moved into the nar and executed via the nifi
> startup routine
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
