szaszm commented on a change in pull request #1252:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798521216
##########
File path: controller/Controller.h
##########
@@ -246,18 +246,18 @@
std::shared_ptr<org::apache::nifi::minifi::core::controller::ControllerService>
configuration->get(org::apache::nifi::minifi::Configure::nifi_provenance_repository_class_name,
prov_repo_class);
// Create repos for flow record and provenance
- const auto prov_repo =
org::apache::nifi::minifi::core::createRepository(prov_repo_class, true,
"provenance");
+ const std::shared_ptr<org::apache::nifi::minifi::core::Repository> prov_repo
= org::apache::nifi::minifi::core::createRepository(prov_repo_class, true,
"provenance");
Review comment:
Is there a specific reason for this change, or is it just personal
preference? I would normally do the opposite change.
##########
File path: extensions/aws/processors/FetchS3Object.h
##########
@@ -27,6 +27,7 @@
#include <utility>
#include <vector>
+#include "io/StreamPipe.h"
Review comment:
I don't see an usage of StreamPipe in this file.
##########
File path: extensions/aws/processors/ListS3.h
##########
@@ -33,6 +33,11 @@ namespace org {
namespace apache {
namespace nifi {
namespace minifi {
+
+namespace core {
+class CoreComponentStateManager;
+}
Review comment:
This seems to be unused.
##########
File path: extensions/aws/processors/ListS3.h
##########
@@ -86,7 +91,7 @@ class ListS3 : public S3Processor {
bool write_object_tags_ = false;
bool write_user_metadata_ = false;
bool requester_pays_ = false;
- std::unique_ptr<minifi::utils::ListingStateManager> state_manager_;
+ std::unique_ptr<minifi::utils::ListingStateManager> state_manager_ = nullptr;
Review comment:
The default constructor of `unique_ptr` does the same thing, no need to
explicitly write `nullptr`
##########
File path: extensions/aws/processors/PutS3Object.h
##########
@@ -30,6 +30,7 @@
#include <utility>
#include <vector>
+#include "io/StreamPipe.h"
Review comment:
No stream pipes in this file either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
