markap14 commented on pull request #5666: URL: https://github.com/apache/nifi/pull/5666#issuecomment-1035444808
Thanks for putting up the Draft request here, Shane! I've been playing around with it, and I think design works well. A few recommendations, though, around tooltips and defaults to help simplify the configuration and make things more seamless for others: - For "Number of Retry Attempts" I would recommend adding a tooltip that reads something along the lines of: "If a FlowFile is routed to one of the Relationships that is selected for retry, this indicates how many times the FlowFile will be retried before being routed to the associated Relationship. The total number of attempts will be one more than the configured value of Retry attempts." Perhaps a bit less wordy :) - Also for the backoff policy I would recommend a tooltip that explains the difference. When penalizing, the retried FlowFile will be retried after some time, but the processor will process other FlowFiles in the meantime. However, if FlowFile ordering is necessary, Yielding can be used ensure that no other FlowFiles are processed until the first one has completed all retries. - Would also recommend the verbiage "yield processor" rather than "yield entire processor" - re: "Retry Max Backoff Period" - the first time a FlowFile is retried, it will be penalized - or the processor yielded - based on the Penalty Duration / Yield Duration configured in the Settings tab. The second time, the duration will be doubled. And then doubled again, up until the Max Backoff Period. Should probably have a tooltip to explain this also. - I would recommend "Number of Retry Attempts" not default to 0. Perhaps 3 or 5 or 10. Maybe 10 retries is a reasonable default. - Recommend a Max Backoff Period of "10 mins" instead of "30 secs" - 30 secs is a good starting value but I think 10 mins is probably more appropriate for the max amount of time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
