mcgilman commented on a change in pull request #5666:
URL: https://github.com/apache/nifi/pull/5666#discussion_r809367895
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/processor-configuration.jsp
##########
@@ -223,6 +212,52 @@
<div
id="processor-properties-verification-results-listing"
class="verification-results-listing"></div>
</div>
</div>
+ <div id="processor-relationships-tab-content"
class="configuration-tab">
+ <div class="settings-left">
+ <div class="setting">
+ <div class="setting-name">
+ Automatically terminate / retry relationships
+ <div class="fa fa-question-circle" alt="Info"
title="Will automatically terminate or retry FlowFiles sent to a given
relationship if it is not defined elsewhere."></div>
Review comment:
Configuring both retry and auto-terminate is a valid configuration. For
instance, retry 10 times then terminate. The tooltip as-is suggests it's one or
the other. We should clarify that both is valid and that the retry logic
happens before auto-termination.
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
##########
@@ -333,7 +367,11 @@
}
// relationships
- processorConfigDto['autoTerminatedRelationships'] =
marshalRelationships();
+ processorConfigDto['autoTerminatedRelationships'] =
marshalRelationships('terminate');
+ processorConfigDto['retriedRelationships'] =
marshalRelationships('retry');
Review comment:
If there are no relationships being retried, the inputs defining the
retry criteria are hidden. However, below we are always including them in the
request payload. So if the user changes the retry criteria and then unselects
the retry checkbox for all relationships, the inputs are hidden but the new
values are saved.
I believe we have the same scenario for Processors that support Event Driven
scheduling strategy. If scheduling strategy was Timer Driven and the user opens
the configuration dialog and changes the Run Schedule and switches to Event
Driven scheduling strategy the Run Schedule control is hidden but the new value
isn't included in the request payload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
