timeabarna commented on a change in pull request #5303:
URL: https://github.com/apache/nifi/pull/5303#discussion_r805624492
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/utils/AzureEventHubUtils.java
##########
@@ -33,6 +34,10 @@
public final class AzureEventHubUtils {
public static final String MANAGED_IDENTITY_POLICY =
ConnectionStringBuilder.MANAGED_IDENTITY_AUTHENTICATION;
+ public static final AllowableValue AZURE_ENDPOINT = new
AllowableValue("servicebus.windows.net","Azure", "Servicebus endpoint for
general use");
+ public static final AllowableValue AZURE_CHINA_ENDPOINT = new
AllowableValue("servicebus.chinacloudapi.cn", "Azure China", "Servicebus
endpoint for China");
+ public static final AllowableValue AZURE_GERMANY_ENDPOINT = new
AllowableValue("servicebus.cloudapi.de", "Azure Germany", "Servicebus endpoint
for Germany");
+ public static final AllowableValue AZURE_US_GOV_ENDPOINT = new
AllowableValue("servicebus.usgovcloudapi.net", "Azure US Government",
"Servicebus endpoint for US Government");
Review comment:
I agree with you @jfrazee that option 1 is the better solution, modified
the code based on that alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
