[
https://issues.apache.org/jira/browse/MINIFICPP-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi resolved MINIFICPP-1725.
--------------------------------------
Fix Version/s: 0.12.0
Resolution: Fixed
> Upgrade Libwebsockets version and remove workaround in the LibreSSL cmake file
> ------------------------------------------------------------------------------
>
> Key: MINIFICPP-1725
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1725
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Ferenc Gerlits
> Assignee: Gábor Gyimesi
> Priority: Minor
> Fix For: 0.12.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Libwebsockets version (v4.2-stable) we use as a dependency of
> kubernetes-client/c is not prepared for OpenSSL to be compiled together with
> it as a subproject; it expects some flavor of OpenSSL to be already present
> on the system.
> There is a workaround for this problem in {{cmake/BundledLibreSSL.cmake}}:
> {noformat}
> set(OPENSSL_INCLUDE_DIRS "${OPENSSL_INCLUDE_DIR}" CACHE STRING "" FORCE)
> # workaround for libwebsockets
> {noformat}
> but it would be good if we did not need it.
> I fixed the problem in the 4.2 version in
> [https://github.com/warmcat/libwebsockets/pull/2535], and this fix is
> available in Libwebsockets version >= 4.3.1. However, other changes in
> version 4.3 stop this from working again. CMake now fails with this error:
> {noformat}
> CMake Error in build/_deps/websockets-src/lib/CMakeLists.txt:
> Target "websockets" INTERFACE_INCLUDE_DIRECTORIES property contains path:
> "/home/fgerlits/src/minifi/build/thirdparty/libressl-install/include"
> which is prefixed in the build directory.
> CMake Error in build/_deps/websockets-src/lib/CMakeLists.txt:
> Target "websockets" INTERFACE_INCLUDE_DIRECTORIES property contains path:
> "/home/fgerlits/src/minifi/build/thirdparty/libressl-install/include"
> which is prefixed in the build directory.Target "websockets"
> INTERFACE_INCLUDE_DIRECTORIES property contains path:
> "/home/fgerlits/src/minifi/build/thirdparty/libressl-install/include"
> which is prefixed in the source directory.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
