szaszm commented on a change in pull request #1266: URL: https://github.com/apache/nifi-minifi-cpp/pull/1266#discussion_r809288111
########## File path: extensions/azure/processors/ListAzureBlobStorage.h ########## @@ -0,0 +1,78 @@ +/** + * @file ListAzureBlobStorage.h + * ListAzureBlobStorage class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <utility> +#include <vector> + +#include "core/Property.h" +#include "AzureBlobStorageProcessorBase.h" +#include "core/logging/LoggerConfiguration.h" + +class ListAzureBlobStorageTestsFixture; + +namespace org::apache::nifi::minifi::azure::processors { + +class ListAzureBlobStorage final : public AzureBlobStorageProcessorBase { + public: + SMART_ENUM(EntityTracking, + (NONE, "none"), + (TIMESTAMPS, "timestamps") + ) Review comment: Consider using a raw enum class with [magic_enum](https://github.com/Neargye/magic_enum) (new third party lib) ########## File path: docker/test/integration/MiNiFi_integration_test_driver.py ########## @@ -222,6 +222,13 @@ def check_container_log_contents(self, container_engine, line, timeout_seconds=6 return assert False + def check_minifi_log_does_not_contain(self, line): Review comment: This should probably wait a few seconds to avoid false negatives when the agent would be writing that log message, just didn't get around to do it yet. ########## File path: extensions/azure/processors/AzureBlobStorageSingleBlobProcessorBase.h ########## @@ -0,0 +1,56 @@ +/** + * @file AzureBlobStorageSingleBlobProcessorBase.h + * AzureBlobStorageSingleBlobProcessorBase class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <utility> + +#include "AzureBlobStorageProcessorBase.h" + +namespace org::apache::nifi::minifi::azure::processors { + +class AzureBlobStorageSingleBlobProcessorBase : public AzureBlobStorageProcessorBase { + public: + // Supported Properties + EXTENSIONAPI static const core::Property Blob; Review comment: This class hierarchy is getting out of hand. Please refactor it to use composition instead of inheritance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
