lordgamez commented on a change in pull request #1266:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1266#discussion_r811732385
##########
File path: docker/test/integration/MiNiFi_integration_test_driver.py
##########
@@ -222,6 +222,13 @@ def check_container_log_contents(self, container_engine,
line, timeout_seconds=6
return
assert False
+ def check_minifi_log_does_not_contain(self, line):
Review comment:
Added the option for waiting a specific time period in
5de6272fe5adb9bcc895fd5e6a1ad8f888e297f3, but it's set to 0 in the current use
case as the assertions beforehand already wait for the logs to appear.
##########
File path: extensions/azure/processors/ListAzureBlobStorage.h
##########
@@ -0,0 +1,78 @@
+/**
+ * @file ListAzureBlobStorage.h
+ * ListAzureBlobStorage class declaration
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <utility>
+#include <vector>
+
+#include "core/Property.h"
+#include "AzureBlobStorageProcessorBase.h"
+#include "core/logging/LoggerConfiguration.h"
+
+class ListAzureBlobStorageTestsFixture;
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+class ListAzureBlobStorage final : public AzureBlobStorageProcessorBase {
+ public:
+ SMART_ENUM(EntityTracking,
+ (NONE, "none"),
+ (TIMESTAMPS, "timestamps")
+ )
Review comment:
In my opinion it would be better to integrate this lib in a separate PR
if it proves to be better than our current implementation. That way we can
replace all the other occurrences of SMART_ENUM as well and have only a single
enum library in our codebase instead of a mixing the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
