ChrisSamo632 commented on a change in pull request #5665:
URL: https://github.com/apache/nifi/pull/5665#discussion_r811409465
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchRecord.java
##########
@@ -86,6 +96,16 @@
resource = SystemResource.MEMORY,
description = "The Batch of Records will be stored in memory until the
bulk operation is performed.")
public class PutElasticsearchRecord extends AbstractPutElasticsearch {
+ static final Relationship REL_FAILED_RECORDS = new Relationship.Builder()
+ .name("errors").description("If a \"Result Record Writer\" is set,
any record that failed to process the way it was " +
Review comment:
This isn't anything to do with the Record Writer output (success or
failure), this is if the Elasticsearch `_bulk` API operation for the document
(that was created from the Record read from the FlowFile) returns an `error:
true` response (or, optionally, returns a 404 `not_found: true` response)
The new `successful` (which I agree isn't a great name) relationship will
then outputs all the other Records read from the input FlowFile where
Elasticsearch **didn't** return an `error: true` response
I agree the language for this Property Descriptor isn't great though (and so
the same for `successful`, how about something like:
> If a "Result Record Writer" is set, any Record(s) corresponding to
Elasticsearch document(s) that resulted in an "error" (within Elasticsearch)
will be routed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
