ChrisSamo632 commented on a change in pull request #5665:
URL: https://github.com/apache/nifi/pull/5665#discussion_r811410471
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchRecord.java
##########
@@ -86,6 +96,16 @@
resource = SystemResource.MEMORY,
description = "The Batch of Records will be stored in memory until the
bulk operation is performed.")
public class PutElasticsearchRecord extends AbstractPutElasticsearch {
+ static final Relationship REL_FAILED_RECORDS = new Relationship.Builder()
+ .name("errors").description("If a \"Result Record Writer\" is set,
any record that failed to process the way it was " +
+ "configured will be sent to this relationship as part of a
failed record set.")
+ .autoTerminateDefault(true).build();
+
+ static final Relationship REL_SUCCESSFUL_RECORDS = new
Relationship.Builder()
Review comment:
I think the existing `success` would be better as `original` and
`errors` as `error_records` - but as you say, that will break backwards
compatibility
Happy to go with `successful_records` for the new relationship as a
compromise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
