[
https://issues.apache.org/jira/browse/NIFI-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632984#comment-15632984
]
ASF GitHub Bot commented on NIFI-969:
-------------------------------------
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/1179
NIFI-969 Added support for standard JSON
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
polish
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-969
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1179
----
commit 8821a46c00be7cff788a56da90bd026cd88946cb
Author: Oleg Zhurakousky <[email protected]>
Date: 2016-11-03T13:24:33Z
NIFI-969 Added support for standard JSON
polish
----
> Add option to use standard JSON or Avro-JSON to ConvertAvroToJSON
> -----------------------------------------------------------------
>
> Key: NIFI-969
> URL: https://issues.apache.org/jira/browse/NIFI-969
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 0.3.0
> Reporter: Ryan Blue
> Assignee: Oleg Zhurakousky
>
> ConvertAvroToJSON uses {{GenericData#toString(GenericRecord)}} to convert to
> JSON. This produces
> [Avro-JSON|https://avro.apache.org/docs/1.7.7/spec.html#json_encoding], which
> probably isn't what most users want because it adds an unexpected layer for
> Avro union types:
> bq. the union schema {{["null","string",...]}} ... would encode: the string
> {{"a"}} as {{{"string": "a"}}} ...
> It would be good to have a conversion that doesn't add those layers as an
> option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
