[ 
https://issues.apache.org/jira/browse/NIFI-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651402#comment-15651402
 ] 

ASF GitHub Bot commented on NIFI-969:
-------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1179#discussion_r87227795
  
    --- Diff: 
nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/ConvertAvroToJSON.java
 ---
    @@ -225,4 +229,14 @@ public void process(final InputStream rawIn, final 
OutputStream rawOut) throws I
             flowFile = session.putAttribute(flowFile, 
CoreAttributes.MIME_TYPE.key(), "application/json");
             session.transfer(flowFile, REL_SUCCESS);
         }
    +
    +    private byte[] toAvroJSON(Schema shcemaToUse, GenericRecord datum) 
throws IOException {
    --- End diff --
    
    typo "shcemaToUse" should be "schemaToUse"


> Add option to use standard JSON or Avro-JSON to ConvertAvroToJSON
> -----------------------------------------------------------------
>
>                 Key: NIFI-969
>                 URL: https://issues.apache.org/jira/browse/NIFI-969
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.3.0
>            Reporter: Ryan Blue
>            Assignee: Oleg Zhurakousky
>
> ConvertAvroToJSON uses {{GenericData#toString(GenericRecord)}} to convert to 
> JSON. This produces 
> [Avro-JSON|https://avro.apache.org/docs/1.7.7/spec.html#json_encoding], which 
> probably isn't what most users want because it adds an unexpected layer for 
> Avro union types:
> bq. the union schema {{["null","string",...]}} ... would encode: the string 
> {{"a"}} as {{{"string": "a"}}} ...
> It would be good to have a conversion that doesn't add those layers as an 
> option.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to