lordgamez commented on a change in pull request #1253:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1253#discussion_r816647770
##########
File path: libminifi/include/core/Property.h
##########
@@ -467,6 +468,16 @@ class ConstrainedProperty : public
std::enable_shared_from_this<ConstrainedPrope
friend class PropertyBuilder;
};
+struct ConfigurationProperty {
+ explicit ConfigurationProperty(std::string_view name_,
gsl::not_null<PropertyValidator*> validator_ =
gsl::make_not_null(StandardValidators::get().VALID_VALIDATOR.get()))
+ : name(name_),
+ validator(validator_) {
Review comment:
According to the [google style
guide](https://google.github.io/styleguide/cppguide.html#Variable_Names) in
case of structs we shouldn't use `_` suffixes for members, I used them on the
local variables for distinguishing them instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
