szaszm commented on a change in pull request #1253:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1253#discussion_r813066948
##########
File path: extensions/http-curl/tests/HTTPHandlers.h
##########
@@ -446,13 +453,122 @@ class HeartbeatHandler : public ServerAwareHandler {
}
assert(found);
(void)found; // unused in release builds
+
+ verifySupportedOperations(root, verify_components, disallowed_properties);
}
- virtual void handleHeartbeat(const rapidjson::Document& root, struct
mg_connection *) {
- verifyJsonHasAgentManifest(root);
+ private:
+ using Metadata = std::unordered_map<std::string,
std::vector<std::unordered_map<std::string, std::string>>>;
+
+ void sendStopOperation(struct mg_connection *conn) {
Review comment:
According to my IDE, `sendStopOperation`, `getOperandsofProperties` and
`verifyMetadata` can be made static.
The casing of `getOperandsofProperties` seems wrong. The second "o" should
be uppercase, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
