fgerlits commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r823541337
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public
std::enable_shared_
if (running_)
return;
running_ = true;
- thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
+ thread_ = std::thread(&ProvenanceRepository::run, this);
Review comment:
I don't think it's urgent. I'll wait for the tests before approving,
then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
