fgerlits commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r823970101
##########
File path:
docker/test/integration/resources/minifi_cpp_with_provenance_repo/minifi.properties
##########
@@ -0,0 +1,32 @@
+nifi.version=0.6.0
Review comment:
also not important at all, but the version should be `0.12.0`
##########
File path: docker/test/integration/minifi/core/ImageStore.py
##########
@@ -111,6 +113,22 @@ def __build_simple_minifi_cpp_image_with_root(self):
return self.__build_image(dockerfile)
+ def __build_minifi_cpp_image_with_provenance_repo(self):
+ dockerfile = dedent("""FROM {base_image}
+ USER root
Review comment:
very minor, but this will create a string like this:
```
FROM {base_image}
USER root
etc
```
in order to get
```
FROM {base_image}
USER root
etc
```
you need to write
```suggestion
dockerfile = dedent("""\
FROM {base_image}
USER root
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
