[
https://issues.apache.org/jira/browse/NIFI-9797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506588#comment-17506588
]
ASF subversion and git services commented on NIFI-9797:
-------------------------------------------------------
Commit 77c45cabc5c236b9b3cb563b143e53abafbd1921 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=77c45ca ]
NIFI-9797 Corrected AccessToken.isExpired() margin calculation
Signed-off-by: Nathan Gough <[email protected]>
This closes #5867.
> AccessToken isExpired broken
> ----------------------------
>
> Key: NIFI-9797
> URL: https://issues.apache.org/jira/browse/NIFI-9797
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.16.0
> Reporter: Lawrence
> Assignee: David Handermann
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While using a build of the current snapshot (1.16.0) so i could use the new
> StandardOAuth2AccessTokenProvider I ran into an issue with how the
> AccessToken got changed to calculate if the token is expired. This is going
> to break potentially a lot of folks using that AccessToken. It's subtracting
> 5000 seconds from the expiresIn property. I think it was assumed that
> expires_in would be in millis also, but it is not, per OAuth standards:
> [https://datatracker.ietf.org/doc/html/rfc6749#section-4.2.2]
> Here is a link to the PR that got merged where I added a comment ( to little
> to late ).
> [https://github.com/apache/nifi/pull/5319#pullrequestreview-909366668]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
