adamdebreceni commented on a change in pull request #1287:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1287#discussion_r835774374
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -712,8 +712,8 @@ void
ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const EventRender&
session.write(flowFile, &wc);
}
session.putAttribute(flowFile, core::SpecialFlowAttribute::MIME_TYPE,
mimeType);
- session.putAttribute(flowFile, "Timezone name", timezone_name_);
- session.putAttribute(flowFile, "Timezone offset", timezone_offset_);
+ session.putAttribute(flowFile, "timezone.name", timezone_name_);
+ session.putAttribute(flowFile, "timezone.offset", timezone_offset_);
Review comment:
I think this change has merit, but I also think that as it currently
stands, it does not address the root cause of the issue, note that we also
(depending on the processor configuration) append all attributes of the "Data"
xml node as flowfile attributes (granted attribute names probably cannot
contain spaces)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
