lordgamez commented on a change in pull request #1287:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1287#discussion_r836213151
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -712,8 +712,8 @@ void
ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const EventRender&
session.write(flowFile, &wc);
}
session.putAttribute(flowFile, core::SpecialFlowAttribute::MIME_TYPE,
mimeType);
- session.putAttribute(flowFile, "Timezone name", timezone_name_);
- session.putAttribute(flowFile, "Timezone offset", timezone_offset_);
+ session.putAttribute(flowFile, "timezone.name", timezone_name_);
+ session.putAttribute(flowFile, "timezone.offset", timezone_offset_);
Review comment:
You are right that that CWEL should not concern itself with other
processors, but as windows event logs forwarded through InvokeHTTP is a use
case that is being implemented by one of our users this should be fixed, also
as Marton mentioned our attribute names should be consistent. The root cause is
that the HTTP headers do not allow these kinds of attributes and we cannot
really do much about that other than adapting our code for this scenario. If we
find other instances like this I think they should also be corrected, but I
don't think we have any other known issues of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
