szaszm commented on code in PR #1306:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1306#discussion_r854095069
##########
extensions/aws/processors/FetchS3Object.cpp:
##########
@@ -74,7 +74,7 @@ std::optional<aws::s3::GetObjectRequestParameters>
FetchS3Object::buildFetchS3Re
const std::shared_ptr<core::ProcessContext> &context,
const std::shared_ptr<core::FlowFile> &flow_file,
const CommonProperties &common_properties) const {
- minifi::aws::s3::GetObjectRequestParameters
get_object_params(common_properties.credentials, client_config_);
+ minifi::aws::s3::GetObjectRequestParameters
get_object_params(common_properties.credentials,
gsl::make_not_null(client_config_.get()));
Review Comment:
I would add a precondition about the validity of `client_config_` in each
member that depends on it, just to explicitly document the requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
