lordgamez commented on code in PR #1306:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1306#discussion_r856141144
##########
extensions/aws/processors/S3Processor.h:
##########
@@ -115,7 +115,7 @@ class S3Processor : public core::Processor {
std::shared_ptr<core::logging::Logger> logger_;
aws::s3::S3Wrapper s3_wrapper_;
- Aws::Client::ClientConfiguration client_config_;
+ std::unique_ptr<Aws::Client::ClientConfiguration> client_config_;
Review Comment:
Good point, makes the PR much simpler as well, updated in
49a58f547453a95fedfac17a992dc21838a4b714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
