szaszm commented on code in PR #1314:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1314#discussion_r856416586
##########
libminifi/src/sitetosite/RawSocketProtocol.cpp:
##########
@@ -240,6 +240,12 @@ bool
RawSiteToSiteClient::initiateCodecResourceNegotiation() {
}
}
+namespace {
+void logPortStateError(std::shared_ptr<core::logging::Logger>& logger,
utils::Identifier port_id, const std::string& error) {
Review Comment:
@adam-markovics that's going to be inlined and optimized out, no variable is
created on the stack, unless you're using `-O0`.
My concern is that it's more complex than the raw calls, but it's shorter as
well, and it's all local, so it doesn't really matter. I'm neutral.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
